Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch pending tower analyses #506

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Patch pending tower analyses #506

merged 8 commits into from
Jan 27, 2025

Conversation

RasmusBurge-CG
Copy link
Contributor

@RasmusBurge-CG RasmusBurge-CG commented Dec 11, 2024 •
edited
Loading

Description

Added

  • Two tests.

Changed

  • The status should now come from Tower. We are not checking if there are no jobs in analysis with Tower as manager.

Fixed

  • Tower analysis should now not show up with the status error when they don't have jobs.

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage: 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b [THIS-BRANCH-NAME] -a

How to test

  • do start a tower analysis and check the response.

Expected test outcome

  • Check that the status is not Error for recently started tower analyses.

Review

  • tests executed by @RasmusBurge-CG
  • "Merge and deploy" approved by @Vince-janv
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@RasmusBurge-CG RasmusBurge-CG requested a review from a team as a code owner December 11, 2024 15:27
@RasmusBurge-CG RasmusBurge-CG mentioned this pull request Dec 11, 2024
Closed
4 tasks
henrikstranneheim
henrikstranneheim reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

ChrOertlin and others added 3 commits December 12, 2024 14:10
@ChrOertlin
add comments for rasmus
8c13e6d
@RasmusBurge-CG @henrikstranneheim
Update trailblazer/constants.py
ba47f7d 
Co-authored-by: Henrik Stranneheim <henrik.stranneheim@scilifelab.se>
@RasmusBurge-CG
Changes after feedback
8a20c36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@RasmusBurge-CG
Copy link
Contributor Author

PR is tested and working on stage. Feel free to let me know if you have any more concerns.

Vince-janv
Vince-janv approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@RasmusBurge-CG RasmusBurge-CG merged commit 5d9a0e5 into master Jan 27, 2025
6 checks passed
@RasmusBurge-CG RasmusBurge-CG deleted the patch-pending-tower-analyses branch January 27, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikstranneheim henrikstranneheim henrikstranneheim left review comments

@ChrOertlin ChrOertlin ChrOertlin left review comments

@Vince-janv Vince-janv Vince-janv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RasmusBurge-CG @henrikstranneheim @ChrOertlin @Vince-janv