feat: add custom labels to docker services #1251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
0utplay
added a commit
that referenced
this pull request
May 10, 2025
…#1616) ### Motivation In #1251 an issue regarding docker configs was resolved. The docker configuration was only read from the service props which is not used by default. The properties are only present in the task and not the service. This PR now fixes the issue and brings support to resolve the config from service & task properties. ### Modification Added a three step process to figure out which configuration to use when resolving properties that might be task / service specific. The order is now: Service -> Task (if present) -> Module Config ### Result The configuration is read correctly
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
…CloudNetService#1616) ### Motivation In CloudNetService#1251 an issue regarding docker configs was resolved. The docker configuration was only read from the service props which is not used by default. The properties are only present in the task and not the service. This PR now fixes the issue and brings support to resolve the config from service & task properties. ### Modification Added a three step process to figure out which configuration to use when resolving properties that might be task / service specific. The order is now: Service -> Task (if present) -> Module Config ### Result The configuration is read correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The docker per task config was not used at all due to the fact it was read from the services configuration but that does not contain the docker config. Furthermore a user requested custom labels for the docker config.
Modification
Added the requested custom labels on a per task basis.
Result
The per task docker config works and the custom labels are applied to the docker container.
Other context
Fixes #1247