fix: implement real wallet connection and address display functionality#131
Merged
SudiptaPaul-31 merged 3 commits intoCloudra-Labs:mainfrom Jul 29, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
@JamesVictor-O Please resolve the merge conflicts and also there are CI test failing |
Contributor
Author
|
@SudiptaPaul-31 conflixts has been resolved, while the cil test failng is from the contract folder, and i did not work on the contract folder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🔧 Fix Wallet Connection and Address Display Issues
🎯 Overview
This PR addresses critical issues with the wallet connection functionality and address display in the ShadowChat application. The changes implement proper Starknet wallet integration, replace mock implementations with real functionality, and improve the overall user experience.
�� Issues Fixed
Primary Issues:
alert()calls instead of actual wallet connection logicSecondary Issues:
�� Changes Made
Core Wallet Integration (
src/components/WalletConnectButtons.tsx)alert()calls with actualuseConnect()from@starknet-react/coreWallet Modal Improvements (
src/components/WalletModal.tsx)Wallet Card Refactor (
src/components/anonymous-profile/wallet-card.tsx)useAccount()hooktruncateAddress()function for better UI displayuseDisconnect()for proper wallet disconnectionTesting
Manual Testing Completed:
Evidence
�� Files Changed
src/components/WalletConnectButtons.tsx- Core wallet connection logicsrc/components/WalletModal.tsx- Enhanced error handling and user feedbackCloses: #128
Type: Bug fix and feature enhancement
Breaking Changes: None