fix: resolve CI workflow formatting issues#134
Closed
Sandijigs wants to merge 5 commits intoCloudra-Labs:mainfrom
Closed
fix: resolve CI workflow formatting issues#134Sandijigs wants to merge 5 commits intoCloudra-Labs:mainfrom
Sandijigs wants to merge 5 commits intoCloudra-Labs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixed contract test formatting to pass scarb fmt --check validation.
Sandijigs
force-pushed
the
fix/workflow-ci-formatting
branch
from
3aa05e6 to
b722819
Compare
Author
|
@SudiptaPaul-31 please review and let me know |
Collaborator
|
@Sandijigs it fails |
Author
|
@SudiptaPaul-31 i have fixed the issue. |
Collaborator
- Pin React to 18.3.1 to fix @starknet-react/core compatibility - Fix Scarb installation in CI workflow with correct version flag - Add npm optimization flags for faster CI builds
- Remove old package-lock.json entries causing React 19 conflicts - Ensure @starknet-react/core@4.0.4 uses React 18.3.1 consistently - Fix ERESOLVE dependency conflicts in CI
Author
|
@SudiptaPaul-31 the errors has been resolved |
Collaborator
|
@Sandijigs if you study the two failing CI's carefully, you'll notice that, firstly, the contract build is failing and two, the e2e test of FE is failing. Your task is simple, make these two succeed and the CI is green. You can test all these in your own forked branch's I'm sure you can do it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed contract test formatting to pass scarb fmt --check validation.
closes #132