forked from aws/amazon-cloudwatch-agent
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-14444: Debug logging for PodStore #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrennz
changed the title
Add Additional Logging to PodStore
(Draft) CP-14444: Add Additional Logging to PodStore
Nov 15, 2023
bdrennz
changed the title
(Draft) CP-14444: Add Additional Logging to PodStore
(Draft) CP-14444: Debug logging for PodStore
Nov 16, 2023
bdrennz
changed the title
(Draft) CP-14444: Debug logging for PodStore
CP-14444: Debug logging for PodStore
Nov 16, 2023
bdrennz
commented
Nov 16, 2023
dmepham
reviewed
Nov 16, 2023
dmepham
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds debug logs for
PodStore
to surface more information aboutcache
operations. This should help with issues where thePodStore
fails to scrape metrics from Pods in a cluster and any other potentialcache
related issues.Most of the logs are added to
PodStore.refreshInternal()
which is ultimately called byPodStore.Decorate()
any time thecache
needs to be refreshed.PodStore
also now implementsExposeCache()
which lists all entries in the cache along with the remaining time to expiry. Assuming the cache is not empty, the output will look something like:There's some other general information about
pods
,nodes
,containers
, etc.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ideally
ExposeCache()
should have a unit test, but validating logs might be more trouble than it's worth.Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make linter