forked from aws/amazon-cloudwatch-agent
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignored - Close without merge #7
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The goal is to reduce the number of metrics transmitted to CloudWatch Logs. The CloudZero platform used the metric type "Pod" to tracks pods across the cluster to allocate spend. All other metric types are unnecessary.
…y track replicaset that are actively tracking pods.
muellerk22
changed the title
Cloudzero daemonset tracking
Cloudzero Deployment tracking
Aug 12, 2022
muellerk22
changed the title
Cloudzero Deployment tracking
Ignored - Close without merge
Aug 12, 2022
Closed due to user error. Another Pull request was created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Replicaset tracking had been removed. This broke rolling up pods to workload type Deployments.
Description of changes
Place back Replicaset tracking in the code but make it more efficient by only caching Replicaset that managed non-zero replicas. i.e. it is actively managing pods.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Create a cluster with 150 nodes and deployed the agent observing the API Server performance and Pod CPU and Memory utilizations.