CP-23050: Validate CloudZero Metrics are available from Kube State Metrics #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrennz
changed the title
bdrennz
commented
Nov 27, 2024
bdrennz
commented
Nov 27, 2024
bdrennz
commented
Nov 27, 2024
bdrennz
commented
Nov 27, 2024
dmepham
requested changes
Dec 2, 2024
roberthocking
requested changes
Dec 2, 2024
There was a problem hiding this comment.
small nit - should this be ksm instead of kms
There was a problem hiding this comment.
Yea that's just things were before
There was a problem hiding this comment.
Cool if I tackle this in the next PR?
evan-cz
pushed a commit
that referenced
this pull request
Jan 13, 2025
* CP-23425: update records incrementally (#65) * writer updates max of 500 records at a time * CP-23425: retry on remote write (#63) * CP-23425: add ability to toggle individual resource types (#64) * [CP-23425] update log line to prevent nil pointer exception, increase k8s client qps (#67) * fix log line * increase qps allowed by k8s client * add busy timeout to db driver * add new test for empty results * Release 0.0.2 release notes (#66) * Add 0.0.2 release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
kube_state_metrics_reachablepost-startjob to also validate that all CloudZero KMS metrics are available. A sample log output from the Job:{ "level": "info", "log_sequence": 6, "msg": "Using endpoint URL: http://192.168.5.249:8080/metrics", <---- Internal IP discovered using the Service Endpoint "op": "ksm", "time": "2024-11-25T08:23:44Z" } { "level": "info", "log_sequence": 7, "msg": "All required metrics found: [kube_pod_info kube_node_info]", <---- Metric Check (subset for now) "op": "ksm", }Part of the Cluster Status Report related to KMS produced by the Job: {\"name\":\"kube_state_metrics_reachable\",\"passing\":true}]}",The log statements show that the job was able to discover the internal IP of the KSM service, find all required metrics, and mark the
kube_state_metrics_reachablejob as complete.It's worth noting that the base branch is
feature/cp-23050, notdevelop. The remaining work will be handled in a subsequent ticket. I hard coded some values temporarily to prove out the functionality until we can get around to the Chart changes in https://cloudzero.atlassian.net/browse/CP-23740.