generated from Cloudzero/template-cloudzero-open-source
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-19493: update chart deployment for new tool #50
Merged
josephbarnett
merged 25 commits into
Cloudzero:develop
from
josephbarnett:cp-19492-update-chart-deployment-for-new-tool
Jul 10, 2024
Merged
CP-19493: update chart deployment for new tool #50
josephbarnett
merged 25 commits into
Cloudzero:develop
from
josephbarnett:cp-19492-update-chart-deployment-for-new-tool
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CP-19793: add image repo information to readme
dmepham
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I just have minor comments. the only thing that I would suggest is adding to the changelog, though I know you had mentioned a github action step for automating that?
JonParsons11350
approved these changes
Jul 10, 2024
dmepham
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-Dependencies
Testing
Checklist
main
manual deployment testing
kube-state-metrics
and existing deployment ofpromethues-node-exporter
service endpointscloudzero-agent-server
pod$ kubectl -n $NS get pods NAME READY STATUS RESTARTS AGE cloudzero-agent-kube-state-metrics-6579b9786b-5hm4h 1/1 Running 0 16s cloudzero-agent-server-6fff4f4d5f-9rzvg 0/2 Init:0/1 0 16s
env-validator
logscloudzero-agent-server
pod in containercloudzero-agent-validator logs
STATUS_TYPE_POD_STARTED
AND that is has the correct dates (first_created_at, ... vsstate_updated_at
)