Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some bugs in endpoints ( Issue: #367 ) & Adding Endpoint to calculate Capital Asset Pricing Model (CAPM) ( Issue: #368) #399

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

Codeansh
Copy link
Contributor

@Codeansh Codeansh commented Jul 1, 2023

Issue #367, bugs are removed.
Issue #368, Add Endpoint to calculate Capital Asset Pricing Model (CAPM).

@Codeansh Codeansh changed the title fixing some bugs in endpoints (Issue: #367) fixing some bugs in endpoints (Issue: #367) & Adding Endpoint to calculate Capital Asset Pricing Model (CAPM) ( Issue: #368) Jul 1, 2023
@Codeansh Codeansh changed the title fixing some bugs in endpoints (Issue: #367) & Adding Endpoint to calculate Capital Asset Pricing Model (CAPM) ( Issue: #368) fixing some bugs in endpoints ( Issue: #367 ) & Adding Endpoint to calculate Capital Asset Pricing Model (CAPM) ( Issue: #368) Jul 1, 2023
@ighoshsubho
Copy link
Collaborator

Everything looks ok, just confirm me with this sharpe_ratio.

@Codeansh
Copy link
Contributor Author

Codeansh commented Jul 1, 2023

Actually in the "helpers/functions.py" file function "sharpe_ratio" was defined twice ( at line 248 and line 1774 ). Due to the duplicate function, the endpoint was not working as expected. The first function is working correctly so I removed the duplicate function ( at line 1774 ). Now the endpoint is working correctly.

fintest

@ighoshsubho ighoshsubho merged commit ad2856e into Clueless-Community:main Jul 1, 2023
@ighoshsubho
Copy link
Collaborator

Actually in the "helpers/functions.py" file function "sharpe_ratio" was defined twice ( at line 248 and line 1774 ). Due to the duplicate function, the endpoint was not working as expected. The first function is working correctly so I removed the duplicate function ( at line 1774 ). Now the endpoint is working correctly.

fintest

Sounds good! Congrats @Codeansh, your PR got merged! Keep contributing like this in GSSOC'23

@Codeansh
Copy link
Contributor Author

Codeansh commented Jul 1, 2023

Actually in the "helpers/functions.py" file function "sharpe_ratio" was defined twice ( at line 248 and line 1774 ). Due to the duplicate function, the endpoint was not working as expected. The first function is working correctly so I removed the duplicate function ( at line 1774 ). Now the endpoint is working correctly.
fintest

Sounds good! Congrats @Codeansh, your PR got merged! Keep contributing like this in GSSOC'23

Thanks @ighoshsubho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants