Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edited the lumpsum error #430

Merged
merged 7 commits into from
Jul 11, 2023
Merged

edited the lumpsum error #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
014ec0a
Update Readme.md
idiotcommerce Jul 7, 2023
43397de
compound interest calculator modified in main
idiotcommerce Jul 7, 2023
bb3a19e
Merge branch 'main' of https://github.com/iditocommerce/fintech-api
idiotcommerce Jul 7, 2023
44213ad
ci: Add .deepsource.toml
deepsource-io[bot] Jul 8, 2023
797d9f3
edited the lumpsum 500 server and corrected
idiotcommerce Jul 11, 2023
f93f340
Merge branch 'main' of https://github.com/iditocommerce/fintech-api
idiotcommerce Jul 11, 2023
1dafefb
Delete .deepsource.toml
ighoshsubho Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

# THIS IS FOR TEST PURPOSE
<h1 align=center> FinTech API v2</h1>

<p align=center>
Expand Down
4 changes: 2 additions & 2 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,9 @@ def payback_period(
description="Calculate compound interest amount",
)
def compound_interest(
request: compoundInterest,
request: compoundInterest
):
return compound_interest_task(request.principal_amount, request.interest_rate, request.time)
return compound_interest_task(request.principal_amount, request.interest_rate, request.years ,request.compounding_period)


# Endpoints to calculate certificate of deposit (CD)
Expand Down
3 changes: 1 addition & 2 deletions tasks/lumpsum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from helpers import functions
from fastapi import HTTPException, status

async def calculate_lumpsum_task(principal: float, interest_rate: float, years: int):
def calculate_lumpsum_task(principal: float, interest_rate: float, years: int):

try:
total_amount = principal * (
Expand Down