[Fixes: #414] Added Endpoint to Calculate MIRR #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritik48
changed the title
|
@ighoshsubho please review this pr |
|
You have not made any changes to the reviews which I did request. Any updates? |
|
@ighoshsubho sorry what updates are you talking about, I don't get it. |
I'm talking abt the reviews I requested, is it all done? |
|
@ighoshsubho yes I have made the required changes. |
|
The changes aren't reflected. maybe its better if you can make a new pr. Will be more clean. |
|
@ighoshsubho alright, I will create a new pr. |
|
Thanks @ritik48, just make a new one and I'll merge once approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #414
Added endpoint to calculate Modified Internal Rate of Return