Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MLH (Major League Hacking) module #1085

Closed
wants to merge 7 commits into from

Conversation

agastya3636
Copy link
Contributor

@agastya3636 agastya3636 commented May 31, 2024

Description

Added MLH (Major League Hacking) module
added mlh folder
created mlh.py
created init.py
updated dev documentation

Resolves: #1049

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

Uploading a screenshot illustrating the approach you developed for validation is required.

Additional Notes/Comments

Any additional remarks or suggestions concerning this pull request are welcome.


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

Copy link
Member

@nikhil25803 nikhil25803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the code locally?

  • Remove all the print statements from the code.
  • Also on the URL using year as 2024, instead you should as for an argument in constructor and replace the in URL.
  • In the docuemntation .md, you have added Create an instance of the classGeeksforGeeks`` Replace it with MLH.

I mean do review your own code before make a PR.

@agastya3636
Copy link
Contributor Author

@nikhil25803 please check it

@nikhil25803
Copy link
Member

image

Returning None for year "2024"

@nikhil25803 nikhil25803 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat:I would like to add module for MLH
2 participants