Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added codeforces_test file #1090

Closed

Conversation

Shraman-jain
Copy link

Description

I have added codeforces_test file and made a slight comment change in hackerrank_test file

Resolves: #945

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

Codeforces_test
Hackerank

Additional Notes/Comments

Added codeforces_test file and made a slight comment change in hackerrank_test file so didn't updated documentation.md file and also hasen't used try-catch techniques since these are unit test files


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

@nikhil25803
Copy link
Member

Hey @Shraman-jain, the test cases are not passed, and an error is being returned.

It must be an error in the Codeforces module, can you fix it? You can raise an error and start working on it or wait for someone to fix it.

@Shraman-jain
Copy link
Author

Shraman-jain commented Jun 1, 2024

Yes Sure @nikhil25803 I can do rewrite whole codeforces module but I can't do it without selenium as I have tried various ways to scrape dynamic content from a website without selenium but couldn't succeed . If you allow use of selenium Ican start working on it.
Please tag this issue in gssoc24

@Shraman-jain
Copy link
Author

Shraman-jain commented Jun 11, 2024

@nikhil25803 Should I proceed with that?Because I don't think there is way for dynamic scrapping without selenium most of the module will have the same issue.I am really curious to contribute in this project and If you have an idea or know anything please tell me i can implement and resolve the error

@nikhil25803 nikhil25803 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: want to add test file for codeforces users.py file
2 participants