Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: libpe_status: Use pcmk_monitor_timeout for recurring monitors #3246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: libpe_status: Use pcmk_monitor_timeout for recurring monitors #3246

wants to merge 1 commit into from
+4 −23

Commits on Oct 27, 2023

  1. Fix: libpe_status: Use pcmk_monitor_timeout for recurring monitors 

    The executor uses pcmk_monitor_timeout, but the controller considers a
recurring monitor to have timed out after its op timeout expires. If
pcmk_monitor_timeout is very long (for example, 240 seconds), a stonith
stop action can fail. In this situation, the monitor is declared as
timed out before the pcmk_monitor_timeout expires, the stop action is
requested, and its timer begins counting down. However, the stop action
can't begin until after the monitor finishes or pcmk_monitor_timeout
expires.

This also makes special handling in controld_execd.c unnecessary.
pcmk__unpack_action_meta() has already replaced the meta timeout with
the pcmk_monitor_timeout.

Closes RHEL-14826 (JIRA).

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
    @nrwahl2
    nrwahl2 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5eb3d24 View commit details
    Browse the repository at this point in the history