Merge branch 'master' of github.com:ClusterM/famicom-dumper-client

README.md

@@ -108,17 +108,17 @@ public interface IMapper
     /// <summary>
     /// Number of the mapper to spore in the iNES header (-1 if none)
     /// </summary>
-    int Number { get; }
+    int Number { get => -1; }
 
     /// <summary>
     /// Number of submapper (0 if none)
     /// </summary>
-    byte Submapper { get; }
+    byte Submapper { get => 0; }
 
     /// <summary>
     /// Name of the mapper to store in UNIF container (null if none)
     /// </summary>
-    string UnifName { get; }
+    string UnifName { get => null; }
 
     /// <summary>
     /// Default PRG size to dump (in bytes)
@@ -128,7 +128,7 @@ public interface IMapper
     /// <summary>
     /// Default CHR size to dump (in bytes)
     /// </summary>
-    int DefaultChrSize { get; }
+    int DefaultChrSize { get => 0; }
 
     /// <summary>
     /// This method will be called to dump PRG
@@ -144,43 +144,42 @@ public interface IMapper
     /// <param name="dumper">FamicomDumperConnection object to access cartridge</param>
     /// <param name="data">This list must be filled with dumped CHR data</param>
     /// <param name="size">Size of CHR to dump requested by user (in bytes)</param>
-    void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size = 0);
+    void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size = 0)
+        => throw new NotSupportedException("This mapper doesn't have a CHR ROM");
 
     /// <summary>
     /// This method will be called to enable PRG RAM
     /// </summary>
     /// <param name="dumper"></param>
-    void EnablePrgRam(IFamicomDumperConnection dumper);
+    void EnablePrgRam(IFamicomDumperConnection dumper)
+        => throw new NotImplementedException("PRG RAM is not supported by this mapper");
 
     /// <summary>
     /// This method must return mirroring type, it can call dumper.GetMirroring() if it's fixed
     /// </summary>
     /// <param name="dumper">FamicomDumperConnection object to access cartridge</param>
     /// <returns>Mirroring type</returns>
-    MirroringType GetMirroring(IFamicomDumperConnection dumper);
-
-    /* Optional properties */
-    /*
+    MirroringType GetMirroring(IFamicomDumperConnection dumper) => dumper.GetMirroring();
+
     /// <summary>
     /// Default PRG RAM size, can be used with NES 2.0
     /// </summary>
-    int DefaultPrgRamSize { get; }
+    public int DefaultPrgRamSize { get => -1; }
 
     /// <summary>
     /// Default CHR RAM size, can be used with NES 2.0
     /// </summary>
-    int DefaultChrRamSize { get; }
+    public int DefaultChrRamSize { get => -1; }
 
     /// <summary>
     /// Default PRG NVRAM size, can be used with NES 2.0
     /// </summary>
-    int DefaultPrgNvramSize { get; }
+    public int DefaultPrgNvramSize { get => -1; }
 
     /// <summary>
     /// Default CHR NVRAM size, can be used with NES 2.0
     /// </summary>
-    int DefaultChrNvramSize { get; }
-    */
+    public int DefaultChrNvramSize { get => -1; }
 }
 ```