Skip to content

Fix pending script verdict promotion for compiled_action #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidahmann merged 1 commit into from
Feb 20, 2026
Merged

Fix pending script verdict promotion for compiled_action #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions governance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,17 @@ func NewRecordFromEvent(event GovernanceEvent, source string) (*Record, error) {
}
}
if strings.TrimSpace(event.Verdict) != "" {
verdict := strings.TrimSpace(event.Verdict)
if recordType == "compiled_action" {
if _, ok := eventPayload["gate_verdict"]; !ok {
eventPayload["gate_verdict"] = strings.TrimSpace(event.Verdict)
if verdict == "pending" {
if _, ok := eventPayload["verdict"]; !ok {
eventPayload["verdict"] = verdict
}
} else if _, ok := eventPayload["gate_verdict"]; !ok {
eventPayload["gate_verdict"] = verdict
}
} else if _, ok := eventPayload["verdict"]; !ok {
eventPayload["verdict"] = strings.TrimSpace(event.Verdict)
eventPayload["verdict"] = verdict
}
}

Expand Down
25 changes: 25 additions & 0 deletions governance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,31 @@ func TestNewRecordFromEventErrors(t *testing.T) {
require.Error(t, err)
}

func TestNewRecordFromEventScriptEvaluationPendingVerdict(t *testing.T) {
r, err := NewRecordFromEvent(GovernanceEvent{
EventID: "evt-pending-script",
Timestamp: "2026-02-20T15:03:00Z",
EventType: "script_evaluation",
Verdict: "pending",
Detail: map[string]any{
"script_hash": "sha256:7777777777777777777777777777777777777777777777777777777777777777",
"tool_sequence": []string{"shell.exec", "http.request"},
"step_count": 2,
"has_conditionals": false,
"has_loops": false,
"composite_risk_class": "limited",
"script_source": "agent_planner",
},
}, "axym")
require.NoError(t, err)
require.Equal(t, "compiled_action", r.RecordType)
require.NoError(t, ValidateRecord(r))

_, hasGateVerdict := r.Event["gate_verdict"]
require.False(t, hasGateVerdict)
require.Equal(t, "pending", r.Event["verdict"])
}

func loadGovernanceEventFixture(t *testing.T, name string) GovernanceEvent {
t.Helper()
path := filepath.Join("testdata", "governance_events", name)
Expand Down
Loading