Add filesystem loading for frameworks and clarify starter definitions#9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa61668d4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| func Load(idOrFile string) (*Framework, error) { | ||
| if info, err := os.Stat(idOrFile); err == nil { |
There was a problem hiding this comment.
Preserve embedded lookup before filesystem probing
Checking os.Stat(idOrFile) before embedded resolution makes built-in framework IDs/file names depend on the caller’s current working directory: any local file named like a built-in (for example eu-ai-act.yaml) will be loaded instead of the embedded starter definition. This is a regression introduced here because List() calls Load() with embedded file names, so proof frameworks list can silently show user-local data or fail if that local file is invalid, breaking deterministic built-in behavior.
Useful? React with 👍 / 👎.
Summary
framework.Load/proof.LoadFramework(path)while preserving built-in embedded framework IDsproof frameworks showhelp text to support id-or-path and add a human summary line toproof frameworks listValidation