Skip to content

Comments

plan: add code review remediation backlog#34

Merged
davidahmann merged 1 commit intomainfrom
codex/adhoc-plan-code-review-findings
Feb 21, 2026
Merged

plan: add code review remediation backlog#34
davidahmann merged 1 commit intomainfrom
codex/adhoc-plan-code-review-findings

Conversation

@davidahmann
Copy link
Contributor

Problem

The code review surfaced three contract-level findings that need an execution-ready remediation plan before implementation:

  • P1: fail-open org/repo acquisition can fabricate repos when GitHub API settings are unset.
  • P1: regress pipeline treats policy findings as tools, causing false drift.
  • P2: non-approved manual lifecycle transitions can retain approval_status=valid.

Changes

  • Added /Users/davidahmann/Projects/wrkr/product/code_review.md as an adhoc backlog plan.
  • Structured the plan into prioritized epics/stories with:
    • tasks, repo paths, run commands
    • mandatory test requirements
    • per-story matrix wiring
    • recommendation traceability
    • minimum-now sequencing and definition of done
  • Preserved Wrkr non-negotiables (determinism, fail-closed behavior, contract stability).

Validation

  • make prepush-full
  • /Users/davidahmann/Projects/wrkr/.tmp/wrkr scan --path /Users/davidahmann/Projects/wrkr/scenarios/wrkr/scan-mixed-org/repos --state /Users/davidahmann/Projects/wrkr/.tmp/ship-scan-state.json --json

@davidahmann davidahmann merged commit 08b6336 into main Feb 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant