feat(vitest-plugin): always run codspeed benchmarks when using the pl…

…ugin, as hooks are not supported in the default vitest benchmark runner
CodSpeedHQ · Jan 24, 2024 · 09429f2 · 09429f2
1 parent 248b470
commit 09429f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/vitest-plugin/src/__tests__/index.test.ts b/packages/vitest-plugin/src/__tests__/index.test.ts
@@ -43,7 +43,7 @@ describe("codSpeedPlugin", () => {
       expect(applyPlugin).toBe(false);
     });
 
-    it("should not apply the plugin when there is no instrumentation", async () => {
+    it("should apply the plugin when there is no instrumentation", async () => {
       coreMocks.Measurement.isInstrumented.mockReturnValue(false);
 
       const applyPlugin = applyPluginFunction(
@@ -52,9 +52,9 @@ describe("codSpeedPlugin", () => {
       );
 
       expect(console.warn).toHaveBeenCalledWith(
-        "[CodSpeed] bench detected but no instrumentation found, falling back to default vitest runner"
+        "[CodSpeed] bench detected but no instrumentation found"
       );
-      expect(applyPlugin).toBe(false);
+      expect(applyPlugin).toBe(true);
     });
 
     it("should apply the plugin when there is instrumentation", async () => {

diff --git a/packages/vitest-plugin/src/index.ts b/packages/vitest-plugin/src/index.ts
@@ -27,10 +27,7 @@ export default function codspeedPlugin(): Plugin {
         return false;
       }
       if (!Measurement.isInstrumented()) {
-        console.warn(
-          `[CodSpeed] bench detected but no instrumentation found, falling back to default vitest runner`
-        );
-        return false;
+        console.warn("[CodSpeed] bench detected but no instrumentation found");
       }
       return true;
     },