feat(core): replace sync-request by sync-request-curl to prevent hang…

…ing leaked handle
CodSpeedHQ · Jan 18, 2024 · b4659ef · b4659ef
1 parent 87735c5
commit b4659ef
Show file tree

Hide file tree

Showing 5 changed files with 358 additions and 212 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -31,6 +31,6 @@
     "find-up": "^6.3.0",
     "form-data": "^4.0.0",
     "node-gyp-build": "^4.6.0",
-    "sync-request": "^6.1.0"
+    "sync-request-curl": "^2.1.10"
   }
 }
diff --git a/packages/core/rollup.config.ts b/packages/core/rollup.config.ts
@@ -27,6 +27,6 @@ export default defineConfig([
       { file: pkg.module, format: "es", sourcemap: true },
     ],
     plugins: jsPlugins(pkg.version),
-    external: ["sync-request"],
+    external: ["sync-request-curl"],
   },
 ]);
diff --git a/packages/core/src/mongoMeasurement.ts b/packages/core/src/mongoMeasurement.ts
@@ -1,4 +1,4 @@
-import request from "sync-request";
+import request from "sync-request-curl";
 import {
   InstrumentationStatus,
   MongoTracer,

diff --git a/packages/vitest-plugin/vitest.config.ts b/packages/vitest-plugin/vitest.config.ts
@@ -10,5 +10,7 @@ export default defineConfig({
   test: {
     exclude: ["**/tests/**/*", "**/.rollup.cache/**/*"],
     mockReset: true,
+    // needed for `sync-request-curl` to work, see https://github.com/vitest-dev/vitest/issues/740#issuecomment-1042648373
+    pool: "forks",
   },
 });