Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/support node 18 #11

Merged
merged 20 commits into from
Jun 29, 2023
Merged

feat/support node 18 #11

merged 20 commits into from
Jun 29, 2023

Conversation

adriencaccia
Copy link
Member

@adriencaccia adriencaccia commented Jun 20, 2023

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 21, 2023

CodSpeed Performance Report

Merging #11 feat/support-node-18 (e605ffc) will degrade performances by 81.85%.

Summary

🔥 0 improvements
❌ 4 regressions
✅ 0 untouched benchmarks

🆕 60 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/support-node-18 Change
switch 1 156.7 µs 395 µs -60.32%
switch 2 173.8 µs 239.6 µs -27.46%
RegExp#test 142.2 µs 783.3 µs -81.85%
String#indexOf 135.2 µs 200.5 µs -32.57%
🆕 switch 1 N/A 223.6 µs N/A
🆕 switch 2 N/A 240.2 µs N/A
🆕 switch 1 N/A 240.4 µs N/A
🆕 switch 2 N/A 254.4 µs N/A
🆕 test_recursive_fibo_10 N/A 757.7 µs N/A
🆕 test_recursive_fibo_20 N/A 15.3 ms N/A
🆕 test_recursive_cached_fibo_10 N/A 2 ms N/A
🆕 test_recursive_cached_fibo_20 N/A 438.2 µs N/A
🆕 test_recursive_cached_fibo_30 N/A 333.9 µs N/A
🆕 test_iterative_fibo_10 N/A 875.7 µs N/A
🆕 test_iterative_fibo_100 N/A 1.4 ms N/A
🆕 test sync baz 10 N/A 1.5 ms N/A
🆕 test sync baz 100 N/A 259.6 µs N/A
🆕 test async baz 10 N/A 3.5 ms N/A
🆕 test async baz 100 N/A 2.6 ms N/A
🆕 test_recursive_fibo_10 N/A 2.3 ms N/A
🆕 test_recursive_fibo_20 N/A 10 ms N/A
🆕 test_recursive_cached_fibo_10 N/A 1.8 ms N/A
🆕 test_recursive_cached_fibo_20 N/A 646.1 µs N/A
🆕 test_recursive_cached_fibo_30 N/A 621.5 µs N/A
🆕 test_iterative_fibo_10 N/A 1.1 ms N/A
🆕 test_iterative_fibo_100 N/A 554.5 µs N/A
🆕 test sync baz 10 N/A 2.1 ms N/A
🆕 test sync baz 100 N/A 385.5 µs N/A
🆕 test async baz 10 N/A 8 ms N/A
🆕 test async baz 100 N/A 974.6 µs N/A
🆕 switch 1 N/A 232.9 µs N/A
🆕 switch 2 N/A 499.4 µs N/A
🆕 switch 1 N/A 240.2 µs N/A
🆕 switch 2 N/A 1.2 ms N/A
🆕 RegExp#test N/A 206.7 µs N/A
🆕 String#indexOf N/A 197.7 µs N/A
🆕 RegExp#test N/A 211.7 µs N/A
🆕 String#indexOf N/A 202.8 µs N/A
🆕 test_recursive_fibo_10 N/A 1.4 ms N/A
🆕 test_recursive_fibo_20 N/A 19.4 ms N/A
🆕 test_recursive_cached_fibo_10 N/A 1.3 ms N/A
🆕 test_recursive_cached_fibo_20 N/A 562.3 µs N/A
🆕 test_recursive_cached_fibo_30 N/A 321.6 µs N/A
🆕 test_iterative_fibo_10 N/A 774.2 µs N/A
🆕 test_iterative_fibo_100 N/A 506.6 µs N/A
🆕 test sync baz 10 N/A 1.3 ms N/A
🆕 test sync baz 100 N/A 499.8 µs N/A
🆕 test async baz 10 N/A 2 ms N/A
🆕 test async baz 100 N/A 346 µs N/A
🆕 test_recursive_fibo_10 N/A 762.4 µs N/A
🆕 test_recursive_fibo_20 N/A 19.6 ms N/A
🆕 test_recursive_cached_fibo_10 N/A 1.4 ms N/A
🆕 test_recursive_cached_fibo_20 N/A 458.1 µs N/A
🆕 test_recursive_cached_fibo_30 N/A 562.5 µs N/A
🆕 test_iterative_fibo_10 N/A 988.3 µs N/A
🆕 test_iterative_fibo_100 N/A 269.3 µs N/A
🆕 test sync baz 10 N/A 831.9 µs N/A
🆕 test sync baz 100 N/A 481.1 µs N/A
🆕 test async baz 10 N/A 2.2 ms N/A
🆕 test async baz 100 N/A 338.1 µs N/A
🆕 RegExp#test N/A 220.9 µs N/A
🆕 String#indexOf N/A 440.3 µs N/A
🆕 RegExp#test N/A 211.5 µs N/A
🆕 String#indexOf N/A 210.6 µs N/A

@adriencaccia adriencaccia force-pushed the feat/support-node-18 branch 9 times, most recently from a086d43 to 0961143 Compare June 22, 2023 14:00
@adriencaccia adriencaccia requested a review from art049 June 22, 2023 14:44
@adriencaccia adriencaccia force-pushed the feat/support-node-18 branch 2 times, most recently from 9b98c3d to 40db402 Compare June 26, 2023 13:27
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just misses adding them in the uploaded run (waiting for CodSpeedHQ/action#70)

packages/benchmark.js-plugin/src/getCallingFile.ts Outdated Show resolved Hide resolved
@adriencaccia adriencaccia force-pushed the feat/support-node-18 branch 4 times, most recently from f57edd9 to 2b02869 Compare June 27, 2023 18:12
@adriencaccia
Copy link
Member Author

Just misses adding them in the uploaded run (waiting for CodSpeedHQ/action#70)

We cannot have all the bench from the matrix, with the different versions of node. But I can at least add all the benchmarks from the examples, which will of course run with the node version of the repo (ie 18).

.prettierignore Show resolved Hide resolved
@adriencaccia adriencaccia force-pushed the feat/support-node-18 branch 2 times, most recently from 2a797f8 to e605ffc Compare June 29, 2023 11:12
@adriencaccia adriencaccia merged commit e605ffc into main Jun 29, 2023
@adriencaccia adriencaccia deleted the feat/support-node-18 branch June 29, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants