Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/core hooks #23

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix/core hooks #23

merged 3 commits into from
Aug 3, 2023

Conversation

adriencaccia
Copy link
Member

  • test: refactor core mocks
  • fix: make sure teardown is called only once after all the benchmarks ran

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 1, 2023

CodSpeed Performance Report

Merging #23 will degrade performances by 94.08%

Comparing fix/core-hooks (cd532fd) with main (1911138)

Summary

⚡ 3 improvements
❌ 5 (👁 3) regressions
✅ 56 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/core-hooks Change
switch 1 18.8 µs 316.6 µs -94.08%
switch 1 18.9 µs 316 µs -94.02%
switch 2 20.3 µs 17.7 µs +14.94%
👁 test async baz 100 962.5 µs 1,279.1 µs -24.75%
switch 2 20.3 µs 17.7 µs +14.78%
👁 test async baz 100 1.2 ms 2.1 ms -44.35%
test async baz 10 2.2 ms 1.4 ms +52.02%
👁 test_recursive_fibo_10 93.9 µs 389.7 µs -75.89%

@art049
Copy link
Member

art049 commented Aug 2, 2023

Check variance with this fix before merging

@adriencaccia adriencaccia merged commit cd532fd into main Aug 3, 2023
24 of 25 checks passed
@adriencaccia adriencaccia deleted the fix/core-hooks branch August 3, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants