Merged
Conversation
…middleware type, and register assigns users to the inactive group off rip
…148-setup-aws-roles-ben
…rontend connected working
…antshould fully work now
…148-setup-aws-roles-ben
janekamata
reviewed
Nov 15, 2025
Contributor
janekamata
left a comment
There was a problem hiding this comment.
- I'm getting a User account already exists error when creating a new account
- Loading users page seems slow compared to everything else
- Going to users page and then clicking the My Account page puts me back to the login page; if I hit the back button after this My Grants is no longer filtered
aaronashby
reviewed
Nov 15, 2025
Contributor
aaronashby
left a comment
There was a problem hiding this comment.
In UserPositionCard.tsx (in the users folder in the frontend), I use a switch statement on the position, assuming it was a string, so I'd say to change that to UserStatus. It's a small change, but it might work better for design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Briefly list the changes made to the code:
These changes will be listed in order of what is above.
Created the changeStatus route in the user controller, also created a service method that changes the users status in cognito and reflects that change in our dynamo db table as well.
I changed the login method to return the user as a field in the json. This was just making sure that the user is in the response since it should already be in the dynamo db table.
Added in a call to amazon cognito which would put the user in the inactive amazon cognito group
Used camilas changes to the auth provider to make sure when login is called, the user gets put in the auth context. I had a little hiccup since when a object is put in the auth context it is put there as a proxy so in the actual grant page component I had to extract the actual object using mobx toJS method.
Created Routes in the backend to fetch active and inactive users. For active users I fetched the users that had the role of employee and admin.
Used the backend routes to fetch active and inactive users. Created a use effect hook which updates the store with the active and inactive users. The user page has a tenary operator which decides what list of users show this used to be mock users but it now our actual users.
Added into the register method a check that no user has the same email as the current user who is signing up.
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Alot of my verification was manually making sure the page is populated. Some things like active and inactive users I changed the values in the database to get decent values to pop up. That last sentence applies to the my grants as well.
Provide screenshots of any new components, styling changes, or pages.
Test Changes
If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.
I cahnged the login test so that it works with the changes.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!
Need more consistency in the repo
Things that could be added to this pull request