Skip to content

223 dev action confirmation modal#229

Closed
josieek wants to merge 7 commits intomainfrom
223-dev---action-confirmation-modal
Closed

223 dev action confirmation modal#229
josieek wants to merge 7 commits intomainfrom
223-dev---action-confirmation-modal

Conversation

@josieek
Copy link
Contributor

@josieek josieek commented Nov 24, 2025

Closes #223

The following fields are passed into the ActionConfirmation modal:

  1. isOpen - boolean if this should be visible or not
  2. title - the bold text at the very top (Ex: "Delete Grant")
  3. subtitle and boldSubtitle - The text on the next line and the text that should be bolded (Ex: "Are you sure you want to delete" and "{grantText}")
  4. warningMessage - the text in the orange warning box (Ex: "By deleting this grant, they won't be available in the system anymore")
  5. onCloseDelete function - called when user clicks "No, cancel"
  6. onConfirmDelete function - called when user clicks "Yes, confirm"

For an example of using this component, see GrantItem.tsx.

I included a comment explaning this in the code as well.

delete grant abstracted modal

This PR also includes connecting deleting grants to backend which is why so many files are changed. I will elaborate on and fine tune that functionality further in my next ticket once I finish refreshing after editing a grant.

@josieek josieek linked an issue Nov 24, 2025 that may be closed by this pull request
Copy link
Contributor

@janekamata janekamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Ran locally and delete works. Looks good at different window sizes too

@prooflesben prooflesben closed this Dec 5, 2025
@prooflesben prooflesben deleted the 223-dev---action-confirmation-modal branch February 15, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - action confirmation modal

3 participants