255 dev camila/generate docs and log code for the notification module#272
Merged
prooflesben merged 6 commits intomainfrom Jan 29, 2026
Conversation
…255-dev---camila/generate-docs-and-log-code-for-the-notification-module
janekamata
reviewed
Jan 26, 2026
Contributor
janekamata
left a comment
janekamata
left a comment
There was a problem hiding this comment.
Wanted to review and see what's going on for my next ticket. Looks good to meet after scrolling through your code and checking out the generated Swagger docs too
prooflesben
requested changes
Jan 27, 2026
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
in the service on line 40 in just future loggin be specific with what user is being referenced instead
Also when logging instead of just saying when things finish sandwich them with saying doing this operation (code doing said operation) finsihed doing the operation
check over getNotificationByNotificationId for some missing logging
…for-the-notification-module
prooflesben
deleted the
255-dev---camila/generate-docs-and-log-code-for-the-notification-module
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #255
📝 Description
Briefly list the changes made to the code:
✔️ Verification
Verified everything appeared as it should in Swagger UI.
Test Changes
n/a
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!