Open
Conversation
…munity/bcan into implement-auto-logout
There was a problem hiding this comment.
Pull request overview
Implements an 8-hour auto-logout mechanism in the frontend auth context and adds a backend logout endpoint/service method to clear auth cookies (and optionally invalidate the Cognito session).
Changes:
- Frontend: adds an 8-hour
setTimeouttied to authentication state to auto-trigger logout. - Backend: adds
POST /auth/logoutto clear auth cookies and anAuthService.logout()method that calls CognitoglobalSignOut. - Backend tests: adds unit tests for the new
AuthService.logout()behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/src/context/auth/authContext.tsx | Starts/clears an 8-hour timer based on isAuthenticated to auto-call logout() |
| backend/src/auth/auth.service.ts | Adds a logout service method that attempts Cognito globalSignOut |
| backend/src/auth/auth.controller.ts | Adds POST /auth/logout to clear cookies and attempt Cognito session invalidation |
| backend/src/auth/test/auth.service.spec.ts | Adds unit tests for AuthService.logout() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #322
📝 Description
Changes made to the code:
authContext.tsxto start/clear the 8 hour timer on login/logout (respectively)✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Test Changes
If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.
N/A
🏕️ (Optional) Future Work / Notes
Noticed that
/auth/refreshendpoint does not exist for the refresh token; will need to be made in the future.