Skip to content

[SSF-125] Move Food Request Fields#100

Merged
maxn990 merged 21 commits intomainfrom
TN/SSF-125-move-food-request-fields
Feb 26, 2026
Merged

[SSF-125] Move Food Request Fields#100
maxn990 merged 21 commits intomainfrom
TN/SSF-125-move-food-request-fields

Conversation

@Tarun-Nagesh
Copy link

ℹ️ Issue

Closes SSF-125

📝 Description

Moved delivery confirmation fields from Food Requests to Orders and implemented request status logic. This change reflects where delivery details are specific to individual orders instead of the entire request.

Backend Changes:

  1. Created TypeORM migration to move dateReceived, feedback, and photos fields from food_requests table to orders table
  2. Added status field to FoodRequest entity with enum values ACTIVE and CLOSED
  3. Moved confirm delivery endpoint from requests to orders: POST /api/orders/:orderId/confirm-delivery (previously POST /api/requests/:requestId/confirm-delivery)
  4. Implemented automatic request status updates - request closes when all its orders are delivered
  5. Fixed TypeScript compilation by defining local MulterFile interface in aws-s3.service.ts (could be changed later with tsconfig fix instead)

✔️ Verification

  1. Ran migration with yarn typeorm:migrate
  2. Tested confirm delivery endpoint via PowerShell
  3. All tests passing (added new tests for confirm delivery logic)

Copy link

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. Good first pass though! 🥇

Copy link

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more small things. looks great so far!!

@maxn990 maxn990 requested a review from dburkhart07 February 23, 2026 18:50
Copy link

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more things, and just some questions that i wanted your opinions on. looking beautiful so far ⛱️

@maxn990 maxn990 requested a review from dburkhart07 February 24, 2026 01:47
Copy link

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, but looks good.

@maxn990 maxn990 self-assigned this Feb 24, 2026
@maxn990 maxn990 requested a review from sam-schu February 24, 2026 22:31
@maxn990 maxn990 requested a review from sam-schu February 25, 2026 01:11
Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good pending the remaining comments!

@maxn990 maxn990 requested a review from sam-schu February 25, 2026 01:54
Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you resolved this comment and this comment related to the migration, are there changes to the migration file that weren't pushed, or is there a reason you think that is not necessary?

Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the create food request endpoint is no longer taking in dateReceived, feedback, or photos, can we have the frontend no longer send values for those in the request? LGTM after that, thanks!

@maxn990 maxn990 merged commit 1fa29f8 into main Feb 26, 2026
4 checks passed
@maxn990 maxn990 deleted the TN/SSF-125-move-food-request-fields branch February 26, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants