Ddb/ssf 8 admin order management frontend#51
Merged
dburkhart07 merged 46 commits intomainfrom Jan 18, 2026
Merged
Conversation
amywng
requested changes
Oct 8, 2025
amywng
requested changes
Dec 4, 2025
sam-schu
reviewed
Dec 5, 2025
Collaborator
sam-schu
left a comment
There was a problem hiding this comment.
Some initial things I noticed:
- Have you checked with Priya whether we want to display the statuses as we're currently keeping track of them internally, or with the names they have in the Figma?
- Can you check with Priya if "Assignee" should be changed to "Assignees"?
- Can you check with Priya what the page should look like if there's no orders? To me when there's no orders it looks like the page didn't load properly (even though it did)
- If there are no orders, hovering over the right pagination chevron causes it to change color, even though there is only one page
- Can we make it so when you hover over an enabled chevron, the cursor also changes to a pointer?
- Can we cycle through the assignee colors rather than having them be randomly assigned? It looks weird to me when we get the same color twice in a row, and it also feels weird that refreshing the page changes all the colors
amywng
requested changes
Dec 7, 2025
amywng
requested changes
Dec 7, 2025
sam-schu
requested changes
Jan 6, 2026
Collaborator
sam-schu
left a comment
There was a problem hiding this comment.
- Currently, filter and sort act only within the current page, which I assume is not the intended behavior for the design. You can check with Priya, but I assume they should filter and sort across all orders in the table, regardless of which are currently displayed
- Nit: Could the assignee colors be assigned when the orders are fetched, based on the sequence they will initially be shown in the table, and then kept the same (i.e., the same order gets the same color) regardless of any filtering/sorting? Currently, when you change the sorting, the assignee colors don't move with the orders but instead stay the same in each row of the table, which makes it look like nothing is changing.
sam-schu
requested changes
Jan 12, 2026
Collaborator
sam-schu
left a comment
There was a problem hiding this comment.
Unresolved a couple comments
sam-schu
requested changes
Jan 14, 2026
sam-schu
approved these changes
Jan 17, 2026
Collaborator
sam-schu
left a comment
There was a problem hiding this comment.
Would be great if you could leave a comment with the changes you made to setFilterStates about why the comparison is necessary to avoid unnecessary pagination resets - I was confused at first until I realized that the contents of the filter search box is part of the filter states. Feel free to merge after that, looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #8
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
I followed the Figma for the admin order management frontend page. I needed to add a few things in particular such as a slight adjustment to the backend in order to get the SSF pantry representative (the volunteer the admin assigns to the order). Aside from that, a majority of the ticket was a similar design pattern to the admin donation management page.
✔️ Verification
Verified proper UI according to Figma:
🏕️ (Optional) Future Work / Notes