Merged
Conversation
amywng
requested changes
Oct 12, 2025
amywng
requested changes
Oct 12, 2025
amywng
requested changes
Oct 13, 2025
amywng
approved these changes
Oct 13, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
should wait on sam but LGTM!! thx for doing the tests for my method
sam-schu
requested changes
Nov 27, 2025
sam-schu
requested changes
Dec 9, 2025
sam-schu
reviewed
Dec 13, 2025
Collaborator
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
Will be good to merge pending fix of a Nest issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #51
📝 Description
✔️ Verification
Ensured all tests were passing
🏕️ (Optional) Future Work / Notes
I chose not to test upload functionality for the AWS S3 service, as well as any validation of ids. This is because I think we should test these external services separately in their own methods.