forked from Code-4-Community/scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF-102] Add endpoints to update user info #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhuvanh66
wants to merge
22
commits into
main
Choose a base branch
from
BH/SSF-102-Update-User-Info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b968ae0
added update user info endpoint and tests
bhuvanh66 5830938
merge
swarkewalia bd3f846
merge fixes
swarkewalia 061c4a8
some fixes
swarkewalia 8a8420c
Merge branch 'main' into BH/SSF-102-Update-User-Info
swarkewalia 6411d03
Merge branch 'main' into BH/SSF-102-Update-User-Info
swarkewalia dc91943
Merge branch 'main' into BH/SSF-102-Update-User-Info
swarkewalia 3f6119c
update endpoints
swarkewalia 9df9b00
update user entity
swarkewalia 9a7f68f
update service tests
swarkewalia 50ffbec
fix git tests
swarkewalia 4d9140d
switch put to patch
swarkewalia f9ae01b
nits
swarkewalia 3910aaa
Merge branch 'main' into BH/SSF-102-Update-User-Info
swarkewalia a4f5fd1
Merge branch 'main' into BH/SSF-102-Update-User-Info
swarkewalia 7cfbbb5
merge
swarkewalia 118c7a0
refactored service tests
swarkewalia d941e2f
all comments
swarkewalia c35b42b
fix tests
swarkewalia ec6d6cf
merge changes
swarkewalia 6547ec0
prettier
swarkewalia 2122134
test fixes
swarkewalia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { | ||
| IsString, | ||
| IsPhoneNumber, | ||
| IsOptional, | ||
| IsNotEmpty, | ||
| MaxLength, | ||
| } from 'class-validator'; | ||
|
|
||
| export class updateUserInfo { | ||
| @IsOptional() | ||
| @IsString() | ||
swarkewalia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @IsNotEmpty() | ||
| @MaxLength(255) | ||
| firstName?: string; | ||
|
|
||
| @IsOptional() | ||
| @IsString() | ||
| @IsNotEmpty() | ||
| @MaxLength(255) | ||
| lastName?: string; | ||
|
|
||
| @IsOptional() | ||
| @IsString() | ||
swarkewalia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @IsNotEmpty() | ||
| @IsPhoneNumber('US', { | ||
| message: | ||
| 'phone must be a valid phone number (make sure all the digits are correct)', | ||
| }) | ||
| phone?: string; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this more consistent with our other DTOs by naming the file
update-user-info.dto.tsand the classUpdateUserInfoDto?