SSF-92 Volunteer Management Frontend and Add New Volunteer Modal#80
SSF-92 Volunteer Management Frontend and Add New Volunteer Modal#80
Conversation
Making SSF-92 branch up to date with main
…hub.com/Code-4-Community/ssf into jw/SSF-92-volunteer-management-frontend
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few comments, lmk if you have any questions or comments about them! 🎁
| </Link> | ||
| </Button> | ||
| <Table.Cell textAlign="right"> | ||
| <Link color="neutral.700" fontWeight={400} textStyle="p2" variant="underline" href={`/pantry-management/${volunteer.id}`}> |
There was a problem hiding this comment.
This navigation doesn't make sense to me. Can we confirm with Sam/Priya what we want this flow to be like? I thought users could be assigned to multiple pantries, so to navigate to one pantry here doesn't make sense. If they are only being assigned to one pantry, this should be adjusted to get the pantry id through a pantry lookup by user (in other words, we will need to create a new function to find pantry by pantry_user_id), then use that id for navigation.
Let me know if you have any questions about this.
There was a problem hiding this comment.
I assumed it was like a page to see all the pantries of that user.id but to be honest I have no idea what that flow is like. I'll confirm with Sam
There was a problem hiding this comment.
Sam said not to worry about that right now, that page isn't implemented but when it is we can refactor this
| {error} | ||
| </Text> | ||
| )} | ||
| <Flex justifyContent="flex-end" mt={12} gap={4}> |
There was a problem hiding this comment.
Maybe I missed this, but did we confirm that the order ofo the Submit and Cancel button should be reversed from what's in the Figma?
4 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-92
📝 Description
This PR is another frontend PR to update the design of the volunteer management page to match the figma. It also adds the previously absent add new volunteer modal. There is nothing special regarding code decisions; however I did have to handle invalid phone numbers/emails in the form and I did so via an error message similar to the please fill in all fields message. There might be a better way to handle that but it works currently.
http://localhost:4200/volunteer-management
✔️ Verification
Frontend verification to ensure it matches the figma. Ensured adding new volunteers works properly with the new modal.