Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selecting existing and creating tags in form #107

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Allow selecting existing and creating tags in form #107

merged 3 commits into from
Jan 17, 2020

Conversation

jpadilla
Copy link
Contributor

@jpadilla jpadilla commented Jan 17, 2020 •
edited
Loading

This also migrates from taggit to a simple Tag model.

Closes #107 and #96

Screen Shot 2020-01-17 at 11 53 42 AM

Screen Shot 2020-01-17 at 11 53 44 AM

@jpadilla jpadilla marked this pull request as ready for review January 17, 2020 17:07
gcollazo
gcollazo approved these changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@gcollazo gcollazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpadilla jpadilla merged commit 32149c0 into master Jan 17, 2020
@jpadilla jpadilla deleted the tagging branch January 17, 2020 19:02
This was referenced Jan 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcollazo gcollazo gcollazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpadilla @gcollazo