-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gettext to handle translations #79
base: main
Are you sure you want to change the base?
Conversation
as Fedora community member, I'll be pleased to host you on our translation platform it would make it faster for translators to contribute your project, and reduce the follow-up cost (people who want it will be notified when you update your pot file). You don't have to do anything else than: * update the pot file when you do changes in your code * add po files in your project before release have a nice day, thank you for the fun :)
Hey @Jibec Thanks for your contribution. However, I'm struggling to run it: Maybe @ernesgonzalez33 could give it a try as well? I'm wondering if I'm not doing something wrong. Also, I do have one small observation, that since we are using the "locale" files to generate the dropdown menu that allows the user to select language since we don't have the BTW, I think that it would be better to use the TRANSLATION_KEYS instead of normal texts for the translation keys. So, it can solve the |
as far as I understand the doc, you have to manually add the po file in the tool, the same way you did with csv file.
--
Jean-Baptiste
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that those project changes should be part of the PR as well... Right?
So, IMHO to accept this PR it is necessary first to:
- Revert back the translation keys
- Include the 'en_US.po' file (so the language dropbox will work again)
- Fix the translation imports
i understand the requests and will work on it tomorrow :)
--
Jean-Baptiste
|
@Jibec I'm pretty sure that you are not using the Godot version that supports Mono, and that is why you are getting that missing messages.
I'm not sure if there is another option. I mean, you could include the option to "en_US" directly to the dropbox by code, but... I'm not sure how it will work. It needs to be tested. |
as Fedora community member, I'll be pleased to host you on our translation platform
it would make it faster for translators to contribute your project, and reduce the follow-up cost (people who want it will be notified when you update your pot file).
You don't have to do anything else than:
have a nice day, thank you for the fun :)