-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP Document Content Sync #1887
LSP Document Content Sync #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost good to go. Only one thing needs to be changed.
Also while these changes are great, some of them seem unrelated to the main focus and might be better in a separate PR. I get that it's faster to put everything in one, but it makes reviewing and testing a bit harder (and I need to work on this too 😅). Thanks!
Yeah this one was particularly tangled with a few things since I did #1892 on this branch and had to split it off to make it its own PR. I left a few things here that's my bad. |
Description
Note
Requires #1879 to be merged, based on that branch. This will look like it's a massive change until that is merged.Requires CodeEditApp/CodeEditSourceEditor#265 to be merged as it provides the required APIs to make this work.Changes:
LSPContentCoordinator
which manages forwarding content change notifications to the correct language server.Misc related changes:
Related Issues
Checklist
Screenshots
N/A