feat: add char and Character mutator #1019
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
reviewed
Nov 28, 2025
|
|
||
| @Override | ||
| public void write(Character value, DataOutputStream out) throws IOException { | ||
| out.writeShort(value); |
Contributor
There was a problem hiding this comment.
Out of curiosity, why not use writeChar here for consistency with the readChar call above?
(though DataOutput defines both writeChar and writeShort to be implemented in the same way, so this might not matter)
Contributor
Author
There was a problem hiding this comment.
The idea behind using writeShort here was sloppy copy & paste. Nice catch, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot about chars in the past!
Not sure if
@Positiveand@Negative, etc. make sense on chars (the only signed integral in Java? 😆)@InRangecan be used like in the sample fuzz test.