Fix Maven releases #921
Merged
Fix Maven releases #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uses `exports` rather than `runtime_deps` to mark those dependencies that users of the Maven artifact should be allowed to compile against (rather than just being available on the runtime classpath). This is necessary after bazel-contrib/rules_jvm_external@7b0abdc.
|
@fmeum Thanks a lot! |
oetr
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you!
Then we can wait with the next release until bazel-contrib/rules_jvm_external#1308 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages. This still requires bazel-contrib/rules_jvm_external#1308, which can be brought in via an
archive_overrideafter it has been merged or as a patch before that.Work towards #919