London | 25-ITP-Jan | Oussama Mouggal | Sprint 1| Wireframe #1005
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Oussama-Mouggal
added
📅 Sprint 1
There was a problem hiding this comment.
Pull request overview
This PR completes the wireframe assignment by replacing placeholder content with meaningful articles about development topics (Readme files, wireframes, and Git branches) and styling the footer with a fixed position and custom colors.
Changes:
- Updated HTML content with three articles covering development-related topics
- Enhanced footer styling with fixed positioning, background color, and full width
- Replaced external image sources for article illustrations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| Wireframe/index.html | Replaced placeholder content with three complete articles about README files, wireframes, and Git branches; updated header and footer text |
| Wireframe/style.css | Added footer styling properties including fixed positioning, width, background color, and text color |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h2>What is the purpose of a wireframe? | ||
| </h2> |
There was a problem hiding this comment.
The closing h2 tag is on a separate line, which is inconsistent with the formatting of other h2 elements in the file (see line 19 and line 39).
| <h2>What is a branch in Git? | ||
| </h2> |
There was a problem hiding this comment.
The closing h2 tag is on a separate line, which is inconsistent with the formatting of other h2 elements in the file (see line 19).
| position: fixed; | ||
| left: 0; | ||
| bottom: 0; | ||
| width: 100%; | ||
| background-color: #4b3a3a; | ||
| color: white; | ||
| text-align: center; |
There was a problem hiding this comment.
The fixed positioning of the footer combined with width: 100% and bottom: 0 will cause the footer to overlay content at the bottom of the page. The main element has bottom margin (calc(var(--space) * 4)), but this may not be sufficient to prevent content from being hidden under the fixed footer. Consider adding padding-bottom to the body or adjusting the main margin to account for the footer height.
| installation instructions, usage guidelines, and contribution | ||
| protocols. | ||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
The anchor tags have empty href attributes, which will cause the links to reload the current page instead of navigating to intended destinations. Either provide valid URLs or use href="#" if these are placeholder links for future implementation.
| <p> | ||
| The purpose of a wireframe is to provide a visual guide that represents the skeletal framework of a website or application, helping to plan layout and functionality. | ||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
The anchor tags have empty href attributes, which will cause the links to reload the current page instead of navigating to intended destinations. Either provide valid URLs or use href="#" if these are placeholder links for future implementation.
| left: 0; | ||
| bottom: 0; | ||
| width: 100%; | ||
| background-color: #4b3a3a; |
There was a problem hiding this comment.
The hardcoded color value #4b3a3a doesn't follow the design system established in the CSS file. Consider using CSS custom properties (like --ink or --paper) defined in the :root selector to maintain consistency with the design palette.
| bottom: 0; | ||
| width: 100%; | ||
| background-color: #4b3a3a; | ||
| color: white; |
There was a problem hiding this comment.
The hardcoded color "white" doesn't follow the design system established in the CSS file. Consider using CSS custom properties (like --paper) defined in the :root selector to maintain consistency with the design palette.
| <p> | ||
| A branch in Git is a separate line of development that allows multiple people to work on different features or fixes simultaneously without affecting the main codebase. | ||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
The anchor tags have empty href attributes, which will cause the links to reload the current page instead of navigating to intended destinations. Either provide valid URLs or use href="#" if these are placeholder links for future implementation.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot open a new pull request to apply changes based on the comments in this thread |
1 participant
Self checklist
Changelist
Worked on the wireframe assignment using html and css for styling the page.
Questions
I have deleted my old onboarding repo and created this new one because I confused myself working of different branches of the project.