Skip to content

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 2| jq Commands#114

Open
Faithy4444 wants to merge 3 commits intoCodeYourFuture:mainfrom
Faithy4444:lq-commands
Open

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 2| jq Commands#114
Faithy4444 wants to merge 3 commits intoCodeYourFuture:mainfrom
Faithy4444:lq-commands

Conversation

@Faithy4444
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Faithy4444 Faithy4444 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 22, 2025
@illicitonion illicitonion changed the title Cape Town| 25-SDC-July | Faith Muzondo | Sprint 2| Lq Commands Cape Town| 25-SDC-July | Faith Muzondo | Sprint 2| jq Commands Jul 24, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 1, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I just have one comment for one task. Good work on all the others.

jq/script-02.sh Outdated
# The input for this script is the person.json file.
# TODO: Write a command to output the address of the person, all on one line, with a comma between each line.
# Your output should be exactly the string "35 Fashion Street, London, E1 6PX", but should not contain any quote characters.
jq -r '.address[0] + ", " + .address[1]+ ", "+ .address[2]' person.json No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you design a solution which works for any length of address - even with more than 3 lines?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 1, 2025
@LonMcGregor
Copy link

Great work

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 27, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants