Skip to content

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 3 | Implement Shell Tools#249

Open
aydaeslami wants to merge 8 commits intoCodeYourFuture:mainfrom
aydaeslami:ImplementShellTools
Open

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 3 | Implement Shell Tools#249
aydaeslami wants to merge 8 commits intoCodeYourFuture:mainfrom
aydaeslami:ImplementShellTools

Conversation

@aydaeslami
Copy link

@aydaeslami aydaeslami commented Nov 25, 2025

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR includes my solutions to simulate several shell tools.
I used the Commander module to re-implement them.

@aydaeslami aydaeslami added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 25, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on these tasks, i've left some pointers.

Also, as a general note, we try to be consistent in how we structure our projects and files. Can you spot the difference between how you've named your files in cat, ls, and wc?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 23, 2025
Copy link

@eliza-an eliza-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start, just a few notes as I mentioned. Leon added some as well as i saw!

@aydaeslami aydaeslami added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026
@LonMcGregor
Copy link

Good work so far, this task looks done now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants