London | SDC-Nov-25 | Emiliano Uruena | Sprint 3 | Implement Shell Tools#251
Open
Emilianouz wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | SDC-Nov-25 | Emiliano Uruena | Sprint 3 | Implement Shell Tools#251Emilianouz wants to merge 1 commit intoCodeYourFuture:mainfrom
Emilianouz wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Emilianouz
added
Needs Review
LonMcGregor
reviewed
Dec 23, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks, I've left some comments for where it could be improved
LonMcGregor
added
Reviewed
Emilianouz
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
…n a typical system: cat, ls, and wc.
Emilianouz
added
the
Needs Review
|
I think this is everything resolved now. well done |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implementing common shell tools so that they behave like the real versions on a typical system: CAT, LS, WC. Node commander was installed to run in every directory.