Skip to content

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 3 | Implement Shell Tools#324

Open
katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
katarzynakaz:implement-shell-tools-fixed
Open

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 3 | Implement Shell Tools#324
katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
katarzynakaz:implement-shell-tools-fixed

Conversation

@katarzynakaz
Copy link

@katarzynakaz katarzynakaz commented Feb 7, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

js tools.

@katarzynakaz katarzynakaz added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
@katarzynakaz katarzynakaz changed the title Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 3 | Implement Shell Tools Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 4 | Implement Shell Tools Feb 7, 2026
@katarzynakaz katarzynakaz added 📅 Sprint 4 Assigned during Sprint 4 of this module and removed 📅 Sprint 3 Assigned during Sprint 3 of this module labels Feb 8, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 15, 2026
SlideGauge
SlideGauge reviewed Feb 15, 2026
View reviewed changes
Copy link

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note: I notced async/await being used here, I have doubts in necessity of it in this context: we're doing a console utility

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 15, 2026
@katarzynakaz
Copy link
Author

katarzynakaz commented Feb 22, 2026 •
edited
Loading

Thank you for the feedback. I was folllowing the coursework in Sp 4 with the use of async / await but I see your point.
Changes implemented :)

@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@katarzynakaz katarzynakaz added 📅 Sprint 3 Assigned during Sprint 3 of this module and removed 📅 Sprint 4 Assigned during Sprint 4 of this module labels Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@katarzynakaz katarzynakaz changed the title Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 4 | Implement Shell Tools Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 3 | Implement Shell Tools Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@katarzynakaz katarzynakaz added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@katarzynakaz katarzynakaz added ⚙️ bug Something isn't working NotCoursework Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 📅 Sprint 4 Assigned during Sprint 4 of this module ⚙️ bug Something isn't working labels Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SlideGauge SlideGauge SlideGauge left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katarzynakaz @SlideGauge