Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 5 | prep

[katarzynakaz]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

prep tasks

[SlideGauge]

Could you please rearrange/rename prep tasks (instead of 1/2 etc) to the way they're named in https://sdc.codeyourfuture.io/tools/sprints/5/prep/#type-guided-refactorings
?
Otherwise it is a bit hard to deduce which task solved what.

[SlideGauge]

Overall decent work, but some adjustments are needed for clarity.

[katarzynakaz]

Thank you for the feedback. The files are renamed to match the exercises with a corresponding page of prep and the issues are fixed.

[SlideGauge]

Please, remove remaining .DS_Store files

[SlideGauge]

Thanks a lot for renaming the filenames, now much clearer.
A small note here (it is not a problem in this case, but in future may be):
your .py files have spaces in their name which will produce problems if we try to import these files as modules. Whilst it is not a problem in this concrete sprint, in future this should be avoided (use underscores, this is a typical pattern)

[SlideGauge]

Also, could you place trailing newline in files. It hints you with

symbol that this is missing

[SlideGauge]

Good job, most of my comments are about some code organization/filesystem organization, which worthy to remember to maintain. From the point of view of tasks themselves, answers are correct.
Please, adjust the things I mentioned and I'll accept it.

[katarzynakaz]

Thank you very much, listed changes implemented.