Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sub.md #5404

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Update sub.md #5404

merged 6 commits into from
Oct 14, 2024

Conversation

rrayhka
Copy link
Contributor

@rrayhka rrayhka commented Oct 5, 2024 •
edited by Sriparno08
Loading

Description

Issue Solved

Closes #5396

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Oct 5, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries status: under review Issue or PR is currently being reviewed python Python entries enhancement New feature or request and removed new entry New entry or entries labels Oct 5, 2024
SaviDahegaonkar
SaviDahegaonkar approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rrayhka ,
The entry LGTM! I hereby approve this.

content/python/concepts/regex/terms/sub/sub.md Outdated Show resolved Hide resolved
@SaviDahegaonkar SaviDahegaonkar added status: review 1️⃣ completed status: ready for next review hacktoberfest hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest and removed status: under review Issue or PR is currently being reviewed labels Oct 5, 2024
@Sriparno08 Sriparno08 self-assigned this Oct 5, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Oct 5, 2024
@rrayhka rrayhka mentioned this pull request Oct 8, 2024
Closed
3 tasks
Sriparno08
Sriparno08 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @rrayhka!

@Sriparno08 Sriparno08 merged commit 82a905e into Codecademy:main Oct 14, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @rrayhka
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/python/regex/sub

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaviDahegaonkar SaviDahegaonkar SaviDahegaonkar approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@Sriparno08 Sriparno08

@SaviDahegaonkar SaviDahegaonkar

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest python Python entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] Python Regex
4 participants
@rrayhka @CLAassistant @Sriparno08 @SaviDahegaonkar