Update shipping.py with a few comments #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just an extra from line 32 to the end, but the upper codes would work better with the original ones.
|
|
md-coops
reviewed
Jul 30, 2024
| if(weight<2): | ||
| g_price = weight * 1.50 + 20.00 | ||
| print("Ground shipping price is : " + str(g_price)) | ||
| elif(weight>2 and weight <= 6): |
There was a problem hiding this comment.
we don't need to check weight > 2 here as the conditional statement would terminate at the if(weight<2) step. This is why we use elif instead of a new independent if statement. With elif we don't need to re-evaluate the previous condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an extra from line 32 to the end, but the upper codes would work better with the original ones.