-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Layout Dashboard Refactor #4356
Conversation
@Soare-Robert-Daniel when using just Neve, and I go to Neve > Custom Layouts https://vertis.d.pr/i/Srz8zQ I get this |
6b834b9
to
6677d46
Compare
@Soare-Robert-Daniel can we update the testimonial to : Best all-around WP theme Ville Ekman |
otherwise all good |
@Soare-Robert-Daniel noticed that I can't close the popup, we can add a x in the corner that can do that. |
@ineagu, why would it be close? The UI behind the model is a dummy, so free users can not use Custom Layouts. Would you like for the user to explore the interface? Also, if we make it close, it will be a session close, which means if they re-enter, the pop will show again. |
you're right, the ui tricked me :)) it gave me the impression that is working and that I want to see how it works :)) |
@ineagu, with the new testimonial will look like this: |
Looks goodSent from my iPhoneOn Jan 21, 2025, at 5:22 PM, Soare Robert Daniel ***@***.***> wrote:
@ineagu, with the new testimonial will look like this:
image.png (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Soare-Robert-Daniel I suggest we display: none
all the notices on the upsell page, as they are not actionable anyways (you can't close the modal) and they interfere with the page dummy content.
Otherwise things seem to be ok.
good point @abaicus |
f458acb
to
e003862
Compare
Also add the new header section for Custom Layout page which is backward compatible.
e003862
to
58f9dec
Compare
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
edit.php
with a new upsell modal.Will affect visual aspect of the product
YES
Screenshots
Test instructions
Note
Test together with https://github.com/Codeinwp/neve-pro-addon/pull/2968 to get the new table enhancement.
Check before Pull Request is ready:
I have written a test and included it in this PRCloses https://github.com/Codeinwp/neve-pro-addon/issues/2927