Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Layout Dashboard Refactor #4356

Merged
merged 11 commits into from
Jan 28, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 17, 2025

Summary

  • Add new UI elements for the header section (backward compatible).
  • Bring the Custom Layout edit.php with a new upsell modal.

Will affect visual aspect of the product

YES

Screenshots

Screenshot 2025-01-28 at 11 44 43 Screenshot 2025-01-28 at 11 44 28

Test instructions

Note

Test together with https://github.com/Codeinwp/neve-pro-addon/pull/2968 to get the new table enhancement.

  • Check if the changes do not have regressions.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2927

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 17, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 17, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 17, 2025 14:13
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 17, 2025

Plugin build for d5db7ae is ready 🛎️!

@rodica-andronache
Copy link
Contributor

@Soare-Robert-Daniel when using just Neve, and I go to Neve > Custom Layouts https://vertis.d.pr/i/Srz8zQ I get this
Screenshot on 2025-01-17 at 16-56-23

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as draft January 17, 2025 15:17
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 17, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 20, 2025 12:56
@ineagu
Copy link

ineagu commented Jan 21, 2025

@Soare-Robert-Daniel can we update the testimonial to :

Best all-around WP theme
I’ve been using Neve by Themeisle for a few years now, and it’s proven to be the best theme I’ve ever built websites on. It’s lightweight, modern, fast, customizable, and works great with Woocommerce stores too.

Ville Ekman

@ineagu
Copy link

ineagu commented Jan 21, 2025

otherwise all good

@ineagu
Copy link

ineagu commented Jan 21, 2025

@Soare-Robert-Daniel noticed that I can't close the popup, we can add a x in the corner that can do that.

@Soare-Robert-Daniel
Copy link
Contributor Author

@ineagu, why would it be close? The UI behind the model is a dummy, so free users can not use Custom Layouts.

Would you like for the user to explore the interface? Also, if we make it close, it will be a session close, which means if they re-enter, the pop will show again.

@ineagu
Copy link

ineagu commented Jan 21, 2025

you're right, the ui tricked me :)) it gave me the impression that is working and that I want to see how it works :))

@Soare-Robert-Daniel
Copy link
Contributor Author

@ineagu, with the new testimonial will look like this:
image

@ineagu
Copy link

ineagu commented Jan 21, 2025 via email

Copy link
Collaborator

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soare-Robert-Daniel I suggest we display: none all the notices on the upsell page, as they are not actionable anyways (you can't close the modal) and they interfere with the page dummy content.

Google Chrome 2025-01-27 10 19 32

Otherwise things seem to be ok.

@ineagu
Copy link

ineagu commented Jan 27, 2025

good point @abaicus

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the feat/custom-layout-upsell branch 2 times, most recently from f458acb to e003862 Compare January 27, 2025 14:38
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit f500e3c into development Jan 28, 2025
17 of 18 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the feat/custom-layout-upsell branch January 28, 2025 09:50
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants