Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview images not working with offload enabled [closes #801] #803

Merged
merged 1 commit into from
May 8, 2024

Conversation

abaicus
Copy link
Contributor

@abaicus abaicus commented May 7, 2024

Fixes preview mode not replacing Offloaded URLs.

Closes #801

@abaicus abaicus requested a review from selul May 7, 2024 11:15
@pirate-bot
Copy link
Collaborator

Plugin build for a02a284 is ready 🛎️!

@selul selul merged commit 52267f5 into development May 8, 2024
7 of 8 checks passed
@selul selul deleted the fix/offload-post-preview branch May 8, 2024 07:36
@kushh23
Copy link

kushh23 commented May 8, 2024

Hey @abaicus,

I was checking the fix of this PR on my test site and found that the issue with preview images being broken is fixed, but a new issue seems to appear on my instance.

If I am using an offloaded image on my instance, then the image URL that is replaced on the page is not an offloaded version of the image.

For example see here -
this image is offloaded on my site and I have used this same image on a page-
image

But when I preview it, the URL has a wp-content/uploads/ structure
image

The image has been offloaded properly as the original URL of image redirects back to homepage i.e 404 not found. But the image URL still contains the old wp-content URL

See the screencast here for a better understanding - https://vertis.d.pr/v/On8bzO

@kushh23
Copy link

kushh23 commented May 8, 2024

Here is the page in question - https://arrogantcap.s3-tastewp.com/offloading-test/

and credentials

https://arrogantcap.s3-tastewp.com/wp-admin/
username: kushnamdev
password: do8RmkmWchw

@abaicus
Copy link
Contributor Author

abaicus commented May 8, 2024

This is not related to this particular PR but probably happens due to some other changes on the development branch.

@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants