Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load Formbricks survey via internal pages hooks #874

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Soare-Robert-Daniel
Copy link

@Soare-Robert-Daniel Soare-Robert-Daniel commented Feb 19, 2025

All Submissions:

Changes proposed in this Pull Request:

  • Added internal page hooks
  • Remove Formbricks as a dependency
  • Loading survey via internal page hooks

Closes https://github.com/Codeinwp/themeisle/issues/1687

How to test the changes in this Pull Request:

  1. Use the latest Themeisle SDK release.
  2. Go to /wp-admin/admin.php?page=optimole&formbricksDebug=true#dashboard
  3. In the Browser Console you should see:

CleanShot 2025-02-19 at 16 54 37@2x

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review February 19, 2025 16:26
@pirate-bot
Copy link
Collaborator

pirate-bot commented Feb 19, 2025

Plugin build for 4cf3df1 is ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants