[feat] TextField 컴포넌트 구현 (Input, Textarea 공통 컴포넌트)#27
Merged
Conversation
✅ Deploy Preview for thejulge1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
input과 textarea의 통합으로 |
ghdtnals
approved these changes
Apr 25, 2025
almighty55555
approved these changes
Apr 25, 2025
Collaborator
almighty55555
left a comment
There was a problem hiding this comment.
수민님과 같은 의견입니다! TextField.input, TextField.Textarea로 분리하는 게 좋을 것 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
Closes #14
📝 PR 유형
📝작업 내용
공통 컴포넌트 중 TextField 컴포넌트를 구현합니다.
자세한 설명은
TextFieldWiki 페이지를 참고해주세요.스크린샷 (선택)
💬리뷰 요구사항(선택)
asprops를 통해input태그와textarea태그를 호환되게 사용하려다보니,forwardRef를 추가하는 과정에서 타입 정의 코드가 꽤 복잡해진 것 같습니다 ,아예 분리해서 작성하는게 나을 지 고민입니다 하하 😅