Conversation
✅ Deploy Preview for thejulge1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ghdtnals
approved these changes
Apr 30, 2025
Collaborator
ghdtnals
left a comment
There was a problem hiding this comment.
스켈레톤까지 구현하셨네요! 수고하셨습니다👍
almighty55555
approved these changes
Apr 30, 2025
| import Header from "./Header"; | ||
| interface MainLayoutProps { | ||
| isLoggedIn: boolean; | ||
| isLoggedIn?: boolean; |
Collaborator
There was a problem hiding this comment.
MainLayout에서는 isLoggedIn을 필수화하는 게 안전한 방식이라고 생각했는데 옵셔널로 바꾸신 이유가 궁금합니다 🧐
Collaborator
Author
There was a problem hiding this comment.
현재 optional로 변경을 한 것은 임시로 변경한 것입니다
optional로 변경하지 않으면, Router.tsx에서 타입 에러가 발생해서요 😅
나중에 로그인 상태는 결국 전역상태로 관리될 수 밖에 없다고 생각해서 MainLayout props들은 결국 없어질 것이라 예상합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
Closes #39
📝 PR 유형
📝작업 내용
ProfilePage페이지 컴포넌트 구현useUserApplications커스텀 훅 구현profileLoader로직 추가UserApplicationTableSkeleton컴포넌트 구현className속성에animate-skeleton추가하면 애니메이션 자동 적용)MainLayout컴포넌트 일부 수정현재는 직접
userId를 하드코딩하여 연동을 한 상태입니다. 😅추후, 토큰 및 관련 전역 상태가 구현되면 수정하겠습니다. 👍
스크린샷 (선택)
animate-skeleton적용)💬리뷰 요구사항(선택)