-
Notifications
You must be signed in to change notification settings - Fork 16
added my dockerfile #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
001aahad
wants to merge
1
commit into
CodelineAtyab:main
Choose a base branch
from
001aahad:abdulahad-containerize-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #Adding required system | ||
| FROM maven:3.8.1-openjdk-17 AS build | ||
|
|
||
| # Set the working directory | ||
| WORKDIR /app | ||
|
|
||
| # Copy the pom.xml and install dependencies | ||
| COPY pom.xml /app/ | ||
| COPY src /app/src | ||
|
|
||
| #Run command | ||
| RUN mvn clean package -DskipTests | ||
|
|
||
| # contents of the target | ||
| RUN ls -l target/ | ||
|
|
||
| # Use OpenJDK for running the application | ||
| FROM openjdk:17-jdk-slim | ||
|
|
||
| # Set the working directory | ||
| WORKDIR /app | ||
|
|
||
| # Copy the built JAR file from the Maven build stage | ||
| COPY --from=build /app/target/rihal-0.0.1-SNAPSHOT.jar rihal-0.0.1-SNAPSHOT.jar | ||
| ENTRYPOINT ["sh", "-c","java", "-jar", "rihal-0.0.1-SNAPSHOT.jar"] | ||
|
|
||
| # Expose the application port | ||
| EXPOSE 8080 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| services: | ||
| mysql: | ||
| image: mysql | ||
| container_name: mysql | ||
| environment: | ||
| MYSQL_ROOT_PASSWORD: root | ||
| MYSQL_DATABASE: usersystem | ||
| MYSQL_PASSWORD: root | ||
| MYSQL_TCP_PORT: 3307 | ||
| ports: | ||
| - "3307:3307" | ||
| volumes: | ||
| - mysql_data:/var/lib/mysql | ||
| networks: | ||
| - demo-network | ||
|
|
||
| application: | ||
|
|
||
| build: | ||
| context: . | ||
| dockerfile: Dockerfile.dockerfile | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason for specifying .dockerfile as extension ? |
||
| container_name: userinfo | ||
| environment: | ||
| SPRING_DATASOURCE_URL: jdbc:mysql://mysql:3307/usersystem?useSSL=false&serverTimezone=UTC&createDatabaseIfNotExist=true&allowPublicKeyRetrieval=true | ||
| SPRING_DATASOURCE_USERNAME: root | ||
| SPRING_DATASOURCE_PASSWORD: root | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should never push the password on GitHub. |
||
| SPRING_JPA_HIBERNATE_DDL_AUTO: update | ||
| SPRING_JPA_SHOW_SQL: "true" | ||
| ports: | ||
| - "8080:8080" | ||
| depends_on: | ||
| - mysql | ||
| networks: | ||
| - demo-network | ||
| restart: on-failure | ||
| networks: | ||
| demo-network: | ||
|
|
||
| volumes: | ||
| mysql_data: | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any benefit of running java through "sh" and not directly using ENTRYPOINT ["java", "-jar", "/app/your-application.jar"] ?